Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw drawable when changing geometry #3864

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

kosorin
Copy link
Contributor

@kosorin kosorin commented Oct 12, 2023

Drawable is not redrawn correctly when changing position. At least it happens in right/bottom titlebars.

awful.titlebar(c, { position = "right", size = 100, fg = "#222222" }).widget = {
    layout = wibox.layout.stack,
    {
        layout = wibox.layout.flex.horizontal,
        {
            layout = wibox.container.background,
            bg = "#ff9900",
        },
        {
            layout = wibox.container.background,
            bg = "#00ff66",
        },
    },
    {
        widget = wibox.widget.textbox,
        markup = "<span size='250%'>Lorem ipsum</span>",
    },
}
area_changed_bad.mp4

Fixed

area_changed_fixed.mp4

@Elv13 Elv13 closed this Nov 19, 2023
@Elv13 Elv13 reopened this Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #3864 (90a3a99) into master (7ed4dd6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3864      +/-   ##
==========================================
- Coverage   91.03%   91.00%   -0.03%     
==========================================
  Files         901      901              
  Lines       57540    57541       +1     
==========================================
- Hits        52380    52365      -15     
- Misses       5160     5176      +16     
Flag Coverage Δ
gcov 91.00% <100.00%> (-0.03%) ⬇️
luacov 93.71% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
objects/drawable.c 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@mergify mergify bot merged commit 375d9d7 into awesomeWM:master Nov 19, 2023
15 of 18 checks passed
@kosorin kosorin deleted the fix/redraw-drawable branch January 1, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants